Skip to content

Comments

[frenchgovtenergydata] Fix IllegalArgumentException for thing type tempo#19424

Merged
jlaur merged 2 commits intoopenhab:mainfrom
lo92fr:fix-tempo-tariff
Oct 3, 2025
Merged

[frenchgovtenergydata] Fix IllegalArgumentException for thing type tempo#19424
jlaur merged 2 commits intoopenhab:mainfrom
lo92fr:fix-tempo-tariff

Conversation

@lo92fr
Copy link
Contributor

@lo92fr lo92fr commented Oct 2, 2025

Fixes for tempo tariff Handler in Frenchgovtenergydata

The was an error in 5.0 in the format of EMPTY_LINE for tempo tariff.
This 1 line fix correct the issue.
Without it, the thing never come online :(

@lo92fr
fix tempo tariff EMPTY_LINE format
fae4253 
Signed-off-by: Laurent ARNAL <laurent@clae.net>
@lo92fr lo92fr requested a review from clinique as a code owner October 2, 2025 15:59
@lo92fr
Copy link
Contributor Author

lo92fr commented Oct 2, 2025

Hello @clinique,

I've realized that there was a mistake on modification I've made on 5.0 to add tempo tariff on frenchgovenergydata.
This is really a simple fix of 1 line.
Would be great to have it on 5.1.

Laurent.

jlaur
jlaur reviewed Oct 2, 2025
View reviewed changes
Copy link
Contributor

@jlaur jlaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did a quick check wondering about the meaning of that empty line value, and proposed a small refactoring. Forgive me if I misunderstood the intention here.

@jlaur jlaur added the bug An unexpected problem or unintended behavior of an add-on label Oct 2, 2025
@jlaur jlaur changed the title [frenchgovtenergydata] fix tempo tariff EMPTY_LINE format [frenchgovtenergydata] Fix tempo tariff EMPTY_LINE format Oct 2, 2025
@lo92fr
refactor empty_line by on idea from jlaur
6cbd725 
Signed-off-by: Laurent ARNAL <laurent@clae.net>
@lo92fr lo92fr requested a review from jlaur October 3, 2025 07:38
jlaur
jlaur approved these changes Oct 3, 2025
View reviewed changes
Copy link
Contributor

@jlaur jlaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@jlaur
Copy link
Contributor

jlaur commented Oct 3, 2025

Let's wait a bit for @clinique. @lo92fr - can you describe how this impacted users? I would like to rephrase the PR title a bit to make it more release note-friendly. I understand the Thing never comes online. Which status does it have then, and is anything logged?

clinique
clinique approved these changes Oct 3, 2025
View reviewed changes
Copy link
Contributor

@clinique clinique left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. I discovered '.repeat'

@lo92fr
Copy link
Contributor Author

lo92fr commented Oct 3, 2025

It's stay to Unknow status, no other errors message displayed.
But value are not updated.
You can easily not see it if you have previous value for the channel coming from persistance.

@lo92fr
Copy link
Contributor Author

lo92fr commented Oct 3, 2025

make it more release note-friendly. I understand the Thing never comes online. Which status does it have then, and is anything logged?

In the log, there is a trace for the exception:

java.lang.IllegalArgumentException: Incorrect data in ';;;;;;;;;;;;;;;;'
at org.openhab.binding.frenchgovtenergydata.internal.dto.Tariff.(Tariff.java:56) ~[?:?]
at org.openhab.binding.frenchgovtenergydata.internal.dto.TempoTariff.(TempoTariff.java:40) ~[?:?]

@jlaur jlaur changed the title [frenchgovtenergydata] Fix tempo tariff EMPTY_LINE format [frenchgovtenergydata] Fix IllegalArgumentException for thing type tempo Oct 3, 2025
@jlaur jlaur merged commit ebe1d51 into openhab:main Oct 3, 2025
2 checks passed
@jlaur jlaur added this to the 5.1 milestone Oct 3, 2025
jlaur pushed a commit that referenced this pull request Oct 3, 2025
@lo92fr @jlaur
[frenchgovtenergydata] Fix IllegalArgumentException for thing type …
1147b08 
…`tempo` (#19424)

* fix tempo tariff EMPTY_LINE format

Signed-off-by: Laurent ARNAL <laurent@clae.net>
@jlaur jlaur added the backported A PR that has been cherry-picked to a patch release branch label Oct 3, 2025
@jlaur
Copy link
Contributor

jlaur commented Oct 3, 2025

As a regression of #18732, I've backported the fix to 5.0.x.

@lo92fr
Copy link
Contributor Author

lo92fr commented Oct 3, 2025

As a regression of #18732, I've backported the fix to 5.0.x.

Ok, thanks a lot.

Laurent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@clinique clinique clinique approved these changes

@jlaur jlaur jlaur approved these changes

Assignees

No one assigned

Labels

backported A PR that has been cherry-picked to a patch release branch bug An unexpected problem or unintended behavior of an add-on

Projects

None yet

Milestone

5.1

Development

Successfully merging this pull request may close these issues.

3 participants

@lo92fr @jlaur @clinique